Ramesh N has posted comments on this change. Change subject: gluster: vdc query to list storage devices ......................................................................
Patch Set 17: (3 comments) Config values for MountPointsToIgoreInGlusterStorageList should not have space after ','. So changing it to "/,/home,/boot". Patch set to follow. https://gerrit.ovirt.org/#/c/35314/17/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterStorageDevicesQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterStorageDevicesQuery.java: Line 25: Line 26: } Line 27: Line 28: private List<StorageDevice> filterStorageDevices(List<StorageDevice> storageDevices) { Line 29: List<StorageDevice> filteredStorageDevices = new ArrayList<StorageDevice>(); > right left type declaration could be omitted. sorry for missing it here. I will do it. Line 30: List<String> mountPointsToFilterOutList = getMountPointsFilter(); Line 31: List<String> fsTypesToFilterOutList = getFsTypesFilter(); Line 32: Line 33: // Filter out the devices which are not going to be used as storage device for gluster. Line 42: } Line 43: return filteredStorageDevices; Line 44: } Line 45: Line 46: private static List<String> getMountPointsFilter() { > the static modifier could go away Done Line 47: return Arrays.asList(Config.<String> getValue(ConfigValues.MountPointsToIgoreInGlusterStorageList).split(",")); Line 48: Line 49: } Line 50: Line 47: return Arrays.asList(Config.<String> getValue(ConfigValues.MountPointsToIgoreInGlusterStorageList).split(",")); Line 48: Line 49: } Line 50: Line 51: private static List<String> getFsTypesFilter() { > same Done Line 52: return Arrays.asList(Config.<String> getValue(ConfigValues.FileSystemTypesToIgoreInGlusterStorageList) Line 53: .split(",")); Line 54: } -- To view, visit https://gerrit.ovirt.org/35314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1bb0481bd2b34654c28c5990441d1f6f5302ec2 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
