Martin Mucha has posted comments on this change. Change subject: core: removed pointless caching. ......................................................................
Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/29586/17/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java: Line 43: } Line 44: Line 45: public static String getMessage(AuditLogType logType) { Line 46: final String result = getMessageOrNull(logType); Line 47: return result == null ? "" : result; > please replace this line with: Done Line 48: } Line 49: Line 50: protected static String getMessageOrNull(AuditLogType logType) { Line 51: final String key = logType.name(); -- To view, visit https://gerrit.ovirt.org/29586 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7eb5e71aafb8d8fde253d8713fe6cb7f870d3093 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
