Sahina Bose has posted comments on this change. Change subject: gluster: BLL command for volume snapshot create ......................................................................
Patch Set 22: (3 comments) https://gerrit.ovirt.org/#/c/34928/22/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java: Line 51: addCustomValue(GlusterConstants.VOLUME_SNAPSHOT_NAME, getParameters().getSnapshot().getSnapshotName()); Line 52: } Line 53: Line 54: private boolean pauseAndCreateSnapshotForGeoRepSessions() { Line 55: if (georepSessions != null && georepSessions.size() > 0) { You may need a getter for geoRepSessions, and populate it there or in constructor - I think currently it's being set in canDoAction Line 56: for (GlusterGeoRepSession session : georepSessions) { Line 57: if (session.getStatus() != GeoRepSessionStatus.PAUSED) { Line 58: GlusterVolumeEntity slaveVolume = Line 59: getDbFacade().getGlusterVolumeDao().getById(session.getSlaveVolumeId()); Line 125: } Line 126: }); Line 127: Line 128: if (!tranRetVal) { Line 129: return; setSucceeded(false) ? Line 130: } Line 131: Line 132: // Create snapshot for the master volume Line 133: VDSReturnValue retVal = Line 161: new GlusterVolumeGeoRepSessionParameters(volume.getId(), session.getId())); Line 162: if (!sessionResumeRetVal.getSucceeded()) { Line 163: handleVdsErrors(AuditLogType.GLUSTER_VOLUME_GEO_REP_RESUME_FAILED, Line 164: sessionResumeRetVal.getExecuteFailedMessages()); Line 165: return; setSucceeded(false) ? Line 166: } Line 167: } Line 168: } Line 169: } -- To view, visit https://gerrit.ovirt.org/34928 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c27f9e73bac8d6de3022b0dd4e70aa0d8b1494b Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
