Liron Aravot has posted comments on this change. Change subject: vdsbroker: reduced scope of synchronized blocks ......................................................................
Patch Set 1: Code-Review-1 (1 comment) I reviewed just the IrsBrokerCommand part - see related discussion in the BZ before we proceed with it. https://gerrit.ovirt.org/#/c/37947/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 155: Line 156: @Override Line 157: protected void executeVDSCommand() { Line 158: boolean isStartReconstruct = false; Line 159: try { > +1 Removing this lock is problematic in many ways - when this lock is removed you don't have happens-before relationship between the different threads accessing the shared objects, you can have concurrent spm election, concurrent db updates on same records - generally, you can get to many situations that you won't be able to recover from. I'm still not convinced that this lock is an issue that needs to be taken care of - see the related dicussion in the BZ. Line 160: if (getIrsProxy() != null) { Line 161: executeIrsBrokerCommand(); Line 162: } else { Line 163: if (getVDSReturnValue().getVdsError() == null) { -- To view, visit https://gerrit.ovirt.org/37947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d1bfd7b1fc7bfcc6465eae62feda6f1a27ff455 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tim Speetjens <tim.speetj...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
