anmolbabu has posted comments on this change. Change subject: engine : VDS command for creating geo-rep session ......................................................................
Patch Set 20: (5 comments) https://gerrit.ovirt.org/#/c/29833/20/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java: Line 133: CommitRemoveGlusterVolumeBricks("org.ovirt.engine.core.vdsbroker.gluster"), Line 134: StartRebalanceGlusterVolume("org.ovirt.engine.core.vdsbroker.gluster"), Line 135: StopRebalanceGlusterVolume("org.ovirt.engine.core.vdsbroker.gluster"), Line 136: SetupGeoRepMountBroker("org.ovirt.engine.core.vdsbroker.gluster"), Line 137: GetPubKey("org.ovirt.engine.core.vdsbroker.gluster"), > GetGlusterHostsPubKey Done Line 138: WritePubKeys("org.ovirt.engine.core.vdsbroker.gluster"), Line 139: CreateGlusterVolumeGeoRepSession("org.ovirt.engine.core.vdsbroker.gluster"), Line 140: ResumeGeoRepSession("org.ovirt.engine.core.vdsbroker.gluster"), Line 141: AddBricksToGlusterVolume("org.ovirt.engine.core.vdsbroker.gluster"), Line 134: StartRebalanceGlusterVolume("org.ovirt.engine.core.vdsbroker.gluster"), Line 135: StopRebalanceGlusterVolume("org.ovirt.engine.core.vdsbroker.gluster"), Line 136: SetupGeoRepMountBroker("org.ovirt.engine.core.vdsbroker.gluster"), Line 137: GetPubKey("org.ovirt.engine.core.vdsbroker.gluster"), Line 138: WritePubKeys("org.ovirt.engine.core.vdsbroker.gluster"), > WriteGlusterHostsPubKey Done Line 139: CreateGlusterVolumeGeoRepSession("org.ovirt.engine.core.vdsbroker.gluster"), Line 140: ResumeGeoRepSession("org.ovirt.engine.core.vdsbroker.gluster"), Line 141: AddBricksToGlusterVolume("org.ovirt.engine.core.vdsbroker.gluster"), Line 142: ReplaceGlusterVolumeBrick("org.ovirt.engine.core.vdsbroker.gluster"), https://gerrit.ovirt.org/#/c/29833/20/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeGeoRepSessionVDSParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeGeoRepSessionVDSParameters.java: Line 34: public GlusterVolumeGeoRepSessionVDSParameters(Guid serverId, Line 35: String volumeName, Line 36: String slaveHost, Line 37: String slaveVolume, Line 38: Boolean force, > can you put Boolean at end? Done Line 39: String userName) { Line 40: super(serverId, volumeName); Line 41: this.slaveHost = slaveHost; Line 42: this.slaveVolume = slaveVolume; https://gerrit.ovirt.org/#/c/29833/20/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StringWithStatusReturnXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StringWithStatusReturnXmlRpc.java: Line 3: import java.util.Map; Line 4: Line 5: import org.ovirt.engine.core.vdsbroker.irsbroker.StatusReturnForXmlRpc; Line 6: Line 7: public class StringWithStatusReturnXmlRpc extends StatusReturnForXmlRpc { > The name suggests it is a generic class...but it is very specific to geoRep Done Line 8: Line 9: private String geoRepPublicKeys = null; Line 10: Line 11: private static final String GEO_REP_PUB_KEYS = "geoRepPubKeys"; https://gerrit.ovirt.org/#/c/29833/20/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1227: .withOptionalParameter("userName", userName) Line 1228: .withParameter("force", force).build(); Line 1229: Map<String, Object> response = new FutureMap(this.client, request); Line 1230: return new StatusOnlyReturnForXmlRpc(response); Line 1231: } > Please fix formatting will fix this in the next patch set Line 1232: @Override Line 1233: public StatusOnlyReturnForXmlRpc glusterVolumeGeoRepSessionResume(String volumeName, String slaveHostName, String slaveVolumeName, boolean force) { Line 1234: JsonRpcRequest request = new RequestBuilder("GlusterVolume.geoRepSessionResume").withParameter("volumeName", volumeName) Line 1235: .withParameter("remoteHost", slaveHostName) -- To view, visit https://gerrit.ovirt.org/29833 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8164990c5c377481f1b1244ae548f7eca3066b6 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
