Eli Mesika has posted comments on this change.

Change subject: engine: Sync geo-rep config information
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/37109/5/packaging/dbscripts/upgrade/03_06_0940_georep_drop_constraint_config_key.sql
File 
packaging/dbscripts/upgrade/03_06_0940_georep_drop_constraint_config_key.sql:

Line 1: ALTER TABLE ONLY gluster_georep_config
Please elaborate 
What the result you want to achieve here by allowing to change ONLY this table 
and not using CASCADE in the DROP CONSTRAINT which may fail and cause all the 
upgrade process to exit ...


-- 
To view, visit https://gerrit.ovirt.org/37109
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ee0bc7e916df3becfc99b701de8a0c9e95e2a4d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to