Allon Mureinik has posted comments on this change.
Change subject: core: Call spmStart flow upon "Not SPM" error
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1594: getVDSReturnValue().setVdsError(ex.getVdsError());
Line 1595: logException(ex);
Line 1596: if
(VdcBllErrors.SpmStatusError.equals(ex.getVdsError())) {
Line 1597:
getCurrentIrsProxyData().setCurrentVdsId(Guid.Empty);
Line 1598: failover();
This should be done outside of the "if".
Line 1599: }
Line 1600: } catch (IrsOperationFailedNoFailoverException ex) {
Line 1601:
getVDSReturnValue().setExceptionString(ex.toString());
Line 1602: getVDSReturnValue().setExceptionObject(ex);
--
To view, visit http://gerrit.ovirt.org/7682
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9209d35c54269a9d4db1d8daf52b56687d80a38f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
