Alon Bar-Lev has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 5: (4 comments) https://gerrit.ovirt.org/#/c/37886/5/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java: Line 12: Line 13: import java.io.File; Line 14: import java.util.*; Line 15: Line 16: public class ExtensionsToolExecutor { > Yes, but I googled a lot and sl4j can't be configured programmatically. Onl no, as drivers we use java.util.logging Line 17: Line 18: private static final String ARG_HELP = "help"; Line 19: Line 20: private final Logger logger = LoggerFactory.getLogger(ExtensionsToolExecutor.class); https://gerrit.ovirt.org/#/c/37886/5/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/logger/services/LoggerServiceImpl.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/logger/services/LoggerServiceImpl.java: Line 77: List<ExtensionProxy> proxies = ((List<ExtensionProxy>) context.get(Base.GlobalContextKeys.EXTENSIONS)); Line 78: for(ExtensionProxy proxy : proxies) { Line 79: if(!proxy.getContext().<String>get(Base.ContextKeys.INSTANCE_NAME).equals(loggerName)) { Line 80: continue; Line 81: } > OK, but if user specify directory. Which extension should be used from the no, we should also get extension name to use for logger, I think this is in my initial mail of usage. Line 82: proxy.invoke( Line 83: new ExtMap().mput( Line 84: Base.InvokeKeys.COMMAND, Line 85: Logger.InvokeCommands.PUBLISH https://gerrit.ovirt.org/#/c/37886/5/backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/core/arguments.properties File backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/core/arguments.properties: Line 9: arg.log-level.help = file where log will be stored Line 10: arg.log-level.type = required_argument Line 11: arg.log-level.matcher = FINEST|FINER|FINE|CONFIG|INFO|WARNING|SEVERE Line 12: arg.help.name = help Line 13: arg.help.help = show possible modules you can use > Hmm, what is the benefit? And also, how should I decide what prefix I shoul the benefit is allowing maintaining single properties file for multiple usages, this is good for example for engine-manage-domains. yes, you should get the prefix. https://gerrit.ovirt.org/#/c/37886/5/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java: Line 166: arguments.put(name, argument); Line 167: } Line 168: } Line 169: Line 170: private Set<String> getUsageArguments(Properties properties) { > the parseArgument parses whats on command line. this method parse what's in I think you can return more detailed information out of this function to avoid parsing the properties again, but we can improve this afterwards when all other is finished. Line 171: SortedSet<String> args = new TreeSet<>(new Comparator<String>() { Line 172: @Override Line 173: public int compare(String o, String t1) { Line 174: return o.compareTo(t1); -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
