Muli Salem has posted comments on this change.
Change subject: engine: Change setup networks to handle VDSM errors (#851134)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java
Line 101:
Line 102: try {
Line 103: VDSReturnValue retVal = setupNetworksTask.get(timeout,
TimeUnit.SECONDS);
Line 104: if (retVal != null) {
Line 105: VDSBrokerFrontendImpl.handleVdsResult(retVal);
I believe handleVdsResult() can remain non-static if you use
Backend.getInstance().getResourceManager().handleVdsResult().
Line 106:
Line 107: if (retVal.getSucceeded()) {
Line 108:
setSucceeded(TransactionSupport.executeInNewTransaction(updateVdsNetworksInTx(bckndCmdParams)));
Line 109: }
--
To view, visit http://gerrit.ovirt.org/7679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic833efde810e3e204612f4ba522e6c7aaa32c237
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
