Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: asking about retriyng VG creation with force option ......................................................................
Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/37845/10//COMMIT_MSG Commit Message: Line 8: Line 9: On dirty storage devices CreateVG could fail, force option can Line 10: prevent failures destroying any existent data. Line 11: Asking about retriyng VG creation with force option if first Line 12: attempt fails. >From patchset 7: Nir Soffer Feb 18 3:59 PM Please update the commit message to reflect the changes in the code. Explain what was the previous behavior and what is the new flow. Since this change adds a new force option which is available externally, please explain the new option and why it is needed. Line 13: Line 14: Change-Id: I496c34e6b9f0d84443a8d5bc68d77916be6cb504 Line 15: Bug-Url: https://bugzilla.redhat.com/1142098 https://gerrit.ovirt.org/#/c/37845/10/src/plugins/ovirt-hosted-engine-setup/storage/blockd.py File src/plugins/ovirt-hosted-engine-setup/storage/blockd.py: Line 441: ohostedcons.StorageEnv.FORCE_CREATEVG Line 442: ]: Line 443: raise RuntimeError( Line 444: _( Line 445: 'The selected LUN is dirty ' white space at end of the sentence. also, I think it should fit on one line. Line 446: ) Line 447: ) Line 448: Line 449: self.environment[ohostedcons.StorageEnv.GUID] = device['GUID'] -- To view, visit https://gerrit.ovirt.org/37845 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I496c34e6b9f0d84443a8d5bc68d77916be6cb504 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
