Yevgeny Zaspitsky has posted comments on this change. Change subject: engine: add SessionDataContainer.getSessionIdBySeqId method ......................................................................
Patch Set 2: Verified+1 @rnori IIUC "having a map from session id to seq id" would force synchronization between the two maps, which would affect all flows rather than the current code affects only performance of terminate session flow only. I guess because the map you propose is needed from user triggered operation only the current O(n) implementation won't be a big performance issue. In case that new method would be used wider we might reconsider that. -- To view, visit https://gerrit.ovirt.org/38380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4069c594a553c45869bf45cfa680da4c1b65dabb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
