Alexander Wels has posted comments on this change. Change subject: webadmin: Add sessions main tab ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Looks good, just one minor question, which is probably a misunderstanding on my part. Giving +1 for now, but can give +2 if needed. https://gerrit.ovirt.org/#/c/38384/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java: Line 627: Line 628: //Add sessions node under System Line 629: SystemTreeItemModel sessionsItem = new SystemTreeItemModel(); Line 630: sessionsItem.setType(SystemTreeItemType.Sessions); Line 631: sessionsItem.setApplicationMode(ApplicationMode.AllModes); Should this be ApplicationMode.VirtOnly. As the sessions are virt related? Line 632: sessionsItem.setTitle(ConstantsManager.getInstance().getConstants().sessionsTitle()); Line 633: systemItem.addChild(sessionsItem); Line 634: Line 635: if (!ApplicationModeHelper.getUiMode().equals(ApplicationMode.AllModes)) { -- To view, visit https://gerrit.ovirt.org/38384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide80e57411ff075f26cba84cc8a952a05343fdd6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
