Martin Peřina has posted comments on this change.

Change subject: core,restapi,webadmin: encrypt fence agent options
......................................................................


Patch Set 3:

IMO encryptOptions should be displayed only for apc_snmp agent as it's 
mentioned in bug description. Also looking at fence_* agents man page this 
should be really visible only for apc_snmp. So I would do these steps:

1. Alter db scripts to set encryptOptions to false by default
2. Enable user to edit encryptOptions only for apc_snmp agent

-- 
To view, visit https://gerrit.ovirt.org/38392
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60ff2c8663d68a5fcb8771831d36e15932b24ceb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to