Omer Frenkel has posted comments on this change.

Change subject: core: change other OS to 64bit
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/38280/3/packaging/conf/osinfo-defaults.properties
File packaging/conf/osinfo-defaults.properties:

Line 116: os.rhel_4x64.resources.maximum.ram.value = 262144
Line 117: 
Line 118: # rhel5(7, OsType.Linux, false),
Line 119: os.rhel_5.id.value = 7
Line 120: os.rhel_5.bus.value = 32
why this is needed? it is inheriting this value from rhel4 and 3
Line 121: os.rhel_5.name.value = Red Hat Enterprise Linux 5.x
Line 122: os.rhel_5.derivedFrom.value = rhel_4
Line 123: 
Line 124: # rhel_5x64(13, OsType.Linux, true),


Line 128: os.rhel_5x64.resources.maximum.ram.value = 1048576
Line 129: 
Line 130: # rhel6(18, OsType.Linux, false),
Line 131: os.rhel_6.id.value = 18
Line 132: os.rhel_6.bus.value = 32
why this is needed? it is inheriting this value from rhel4 and 3
Line 133: os.rhel_6.name.value = Red Hat Enterprise Linux 6.x
Line 134: os.rhel_6.derivedFrom.value = rhel_5
Line 135: os.rhel_6.devices.audio.value = ich6
Line 136: os.rhel_6.devices.diskInterfaces.value.3.3 = IDE, VirtIO_SCSI, VirtIO


-- 
To view, visit https://gerrit.ovirt.org/38280
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c3eb1d64145b9ee372deda01168f0b9732375b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to