Sahina Bose has posted comments on this change. Change subject: engine: sync job for gluster disk provisioning ......................................................................
Patch Set 11: Code-Review+1 (2 comments) Minor comments https://gerrit.ovirt.org/#/c/36429/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java: Line 17: } Line 18: Line 19: @Override Line 20: protected boolean canDoAction() { Line 21: VDSGroup cluster = getDbFacade().getVdsGroupDao().get(getVds().getVdsGroupId()); You can just call getVdsGroup() Line 22: if (!cluster.supportsGlusterService() Line 23: || !GlusterFeatureSupported.glusterDiskProvisioning(cluster.getCompatibilityVersion())) { Line 24: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_PROVISIONING_NOT_SUPPORTED_BY_CLUSTER); Line 25: } https://gerrit.ovirt.org/#/c/36429/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java: Line 98: * Compatibility version to check for. Line 99: * @return <code>true</code> if disk provisioning feature is enabled, Line 100: * <code>false</code> if it's not. Line 101: */ Line 102: public static boolean glusterDiskProvisioning(Version version) { call it glusterBrickProvisioning? Line 103: return supportedInConfig(ConfigValues.GlusterDiskProvisioningEnabled, version); Line 104: } -- To view, visit https://gerrit.ovirt.org/36429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I651bb51873a96d491c5a5f51147cb72be958985a Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
