Tal Nisan has posted comments on this change. Change subject: engine, webadmin: Allow to specify disk error_policy in Web UI ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Minor comment https://gerrit.ovirt.org/#/c/38329/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskErrorPolicy.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskErrorPolicy.java: Line 4: import java.util.Map; Line 5: Line 6: public enum DiskErrorPolicy { Line 7: Line 8: report("report"), By the Java convention enums should be uppercase so please change to REPORT, ENOSPC... Line 9: enospc("enospc"), Line 10: stop("stop"), Line 11: ignore("ignore"); Line 12: -- To view, visit https://gerrit.ovirt.org/38329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4bed1019f94064b9800fda0fb17a6def46ab221 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
