Lior Vernia has posted comments on this change. Change subject: webadmin: Gluster network role in UI ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/37476/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java: Line 136: } Line 137: glusterNetwork = model; Line 138: } else { Line 139: // Set the management network as gluster Line 140: getManagementNetwork().setGlusterNetwork(true); > Thanks! I'm removing the else, as we don't want the default to go to the ma I'm not sure you really want to. Even if it's possible to have a specific brick not use any network, and instead probe by the hostname, don't you want the default to always be some network? Line 141: } Line 142: } Line 143: model.setGlusterNetwork(value); Line 144: } -- To view, visit https://gerrit.ovirt.org/37476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09660b88ee48024f02eb915ce6c98c27a7064775 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
