Oved Ourfali has submitted this change and it was merged. Change subject: engine: ManageDomainsResult prints null when setConfigValue fails (#851069) ......................................................................
engine: ManageDomainsResult prints null when setConfigValue fails (#851069) When deleting domain we get wrong error messages. This fix it: 1. In ConfigurationProvider we throw ManageDomainsResult with list of strings instead initializing it with the entry, and the error has two sperate arguments. This results in printing a default message instead of the real one. 2. ManageDomainsResult didn't override getMessage method. 3. The output for ManageDomainsResult with no default message was changed to include also enumResult message. Change-Id: If5b7abde0edb700f42563f06160cd7278848ad0e Signed-off-by: Yaniv Bronhaim <ybron...@redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ConfigurationProvider.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsResult.java 2 files changed, 15 insertions(+), 9 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5b7abde0edb700f42563f06160cd7278848ad0e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
