Moti Asayag has posted comments on this change. Change subject: backend: allowing mask as prefix ......................................................................
Patch Set 5: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/36529/5//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-02-23 10:27:12 +0200 Line 6: Line 7: backend: allowing mask as prefix Line 8: Line 9: Longer description using lines' length under 72 chars. please remove those template lines and provide a meaningful description of this patch Line 10: Line 11: With multiple paragraphs if necessary. Line 12: Line 13: Change-Id: I6a33148aa297a9ba592466a827a987d256a83017 https://gerrit.ovirt.org/#/c/36529/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java: Line 119: opts.put(BOOT_PROTOCOL, DHCP_BOOT_PROTOCOL); Line 120: break; Line 121: case STATIC_IP: Line 122: putIfNotEmpty(opts, "ipaddr", iface.getAddress()); Line 123: if (MaskValidator.getInstance().isPrefixValid(iface.getSubnet())) { please add an action item / notify mmucha about this new behavior which should be added to the new setupnetworks api. Line 124: putIfNotEmpty(opts, "prefix", iface.getSubnet().replace("/", "")); Line 125: } Line 126: else { Line 127: putIfNotEmpty(opts, "netmask", iface.getSubnet()); -- To view, visit https://gerrit.ovirt.org/36529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a33148aa297a9ba592466a827a987d256a83017 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
