Dima Kuznetsov has posted comments on this change.

Change subject: api: Add created Disk object on import response
......................................................................


Patch Set 5:

(4 comments)

https://gerrit.ovirt.org/#/c/38255/5/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java:

Line 298: models
> Things that shouldn't happen tend to happen eventually. Please send the exe
Done


https://gerrit.ovirt.org/#/c/38255/5/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java:

Line 7: import org.ovirt.engine.api.resource.ActionResource;
Line 8: import org.ovirt.engine.api.resource.ImageResource;
Line 9: import org.ovirt.engine.core.common.action.ImportRepoImageParameters;
Line 10: import org.ovirt.engine.core.common.action.VdcActionType;
Line 11: import org.ovirt.engine.core.common.businessentities.Disk;
> Import the model class and use fully qualified name of the backend class.
Done
Line 12: import org.ovirt.engine.core.common.businessentities.RepoImage;
Line 13: import org.ovirt.engine.core.common.queries.GetImageByIdParameters;
Line 14: import org.ovirt.engine.core.common.queries.IdQueryParameters;
Line 15: import org.ovirt.engine.core.common.queries.VdcQueryType;


Line 69: class
> Se above, try to import model classes and use fully qualified names for bac
Done


https://gerrit.ovirt.org/#/c/38255/5/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageResource.java
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageResource.java:

Line 28: businessentities
> Import model classes and use fully qualified names for backend classes.
Done


-- 
To view, visit https://gerrit.ovirt.org/38255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7a6203a318763f13fca8f0627bb0188b7eb2984
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Mooli Tayer <mta...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to