Juan Hernandez has posted comments on this change. Change subject: restapi: setting and getting 'maintenance_reason_required' ......................................................................
Patch Set 2: (1 comment) If the new element is something that the user can modify then it must be documented in the RSDL metadata, otherwise it won't be possible to use it with the SDKs or the CLI. https://gerrit.ovirt.org/#/c/38315/2/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 1707: <xs:element name="tunnel_migration" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1708: <xs:element name="trusted_service" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1709: <xs:element name="ha_reservation" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1710: <xs:element name="optional_reason" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1711: <xs:element name="vds_maintenance_reason_required" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Can you elaborate on the meaning of this new element? If we eventually add it I'd suggest to avoid the "vds" prefix, use "host" instead. Line 1712: <xs:element name="ballooning_enabled" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1713: <xs:element ref="display" minOccurs="0" maxOccurs="1"/> Line 1714: <xs:element ref="ksm" minOccurs="0" maxOccurs="1"/> Line 1715: <xs:element ref="serial_number" minOccurs="0" maxOccurs="1" /> -- To view, visit https://gerrit.ovirt.org/38315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie05d5e25b0a65e387027042a5aff425a4010a305 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
