Lior Vernia has posted comments on this change. Change subject: webadmin: allowing prefix as mask staticIP conf ......................................................................
Patch Set 14: (7 comments) https://gerrit.ovirt.org/#/c/35145/14/frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/SubnetMaskValidationTest.java File frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/SubnetMaskValidationTest.java: Line 44: } Line 45: Line 46: @Test Line 47: public void checkValidErrorMessage() { Line 48: runErrorMesaageCheck(false, true, false, false, ErrorMessage.invalidMask); The first argument can be random. Line 49: runErrorMesaageCheck(true, false, false, false, ErrorMessage.badPrefixOrNetmaskFormatMessage); Line 50: runErrorMesaageCheck(false, false, false, false, ErrorMessage.badNetmaskFormatMessage); Line 51: runErrorMesaageCheck(false, true, true, false, ErrorMessage.NoError); Line 52: runErrorMesaageCheck(true, false, true, true, ErrorMessage.NoError); Line 45: Line 46: @Test Line 47: public void checkValidErrorMessage() { Line 48: runErrorMesaageCheck(false, true, false, false, ErrorMessage.invalidMask); Line 49: runErrorMesaageCheck(true, false, false, false, ErrorMessage.badPrefixOrNetmaskFormatMessage); The third argument can be random. Line 50: runErrorMesaageCheck(false, false, false, false, ErrorMessage.badNetmaskFormatMessage); Line 51: runErrorMesaageCheck(false, true, true, false, ErrorMessage.NoError); Line 52: runErrorMesaageCheck(true, false, true, true, ErrorMessage.NoError); Line 53: } Line 46: @Test Line 47: public void checkValidErrorMessage() { Line 48: runErrorMesaageCheck(false, true, false, false, ErrorMessage.invalidMask); Line 49: runErrorMesaageCheck(true, false, false, false, ErrorMessage.badPrefixOrNetmaskFormatMessage); Line 50: runErrorMesaageCheck(false, false, false, false, ErrorMessage.badNetmaskFormatMessage); The third and fourth arguments can be random. Line 51: runErrorMesaageCheck(false, true, true, false, ErrorMessage.NoError); Line 52: runErrorMesaageCheck(true, false, true, true, ErrorMessage.NoError); Line 53: } Line 54: Line 47: public void checkValidErrorMessage() { Line 48: runErrorMesaageCheck(false, true, false, false, ErrorMessage.invalidMask); Line 49: runErrorMesaageCheck(true, false, false, false, ErrorMessage.badPrefixOrNetmaskFormatMessage); Line 50: runErrorMesaageCheck(false, false, false, false, ErrorMessage.badNetmaskFormatMessage); Line 51: runErrorMesaageCheck(false, true, true, false, ErrorMessage.NoError); The first argument can be random. Line 52: runErrorMesaageCheck(true, false, true, true, ErrorMessage.NoError); Line 53: } Line 54: Line 55: private void runErrorMesaageCheck(boolean isPrefixAllowed, Line 48: runErrorMesaageCheck(false, true, false, false, ErrorMessage.invalidMask); Line 49: runErrorMesaageCheck(true, false, false, false, ErrorMessage.badPrefixOrNetmaskFormatMessage); Line 50: runErrorMesaageCheck(false, false, false, false, ErrorMessage.badNetmaskFormatMessage); Line 51: runErrorMesaageCheck(false, true, true, false, ErrorMessage.NoError); Line 52: runErrorMesaageCheck(true, false, true, true, ErrorMessage.NoError); The third argument can be random. Line 53: } Line 54: Line 55: private void runErrorMesaageCheck(boolean isPrefixAllowed, Line 56: boolean isNetmaskValidFormat, Line 51: runErrorMesaageCheck(false, true, true, false, ErrorMessage.NoError); Line 52: runErrorMesaageCheck(true, false, true, true, ErrorMessage.NoError); Line 53: } Line 54: Line 55: private void runErrorMesaageCheck(boolean isPrefixAllowed, Typo in the method name. Line 56: boolean isNetmaskValidFormat, Line 57: boolean isNetmaskValidValue, Line 58: boolean isPrefixValid, Line 59: ErrorMessage errorType) { Line 70: Line 71: final String exceptionMessage = Line 72: String.format("Failed to validate subnet result message: expected: %s\tresult: %s\t for: isPrefixAllowed: %b\tisNetmaskValidFormat: %b\t isMaskValid: %b\t isPrefixValid: %b", //$NON-NLS-1$ Line 73: errorType.name(), Line 74: actualResult.getReasons().isEmpty()? ErrorMessage.NoError:actualResult.getReasons().get(0), This isn't formatted. As usual. Line 75: isPrefixAllowed, Line 76: isNetmaskValidFormat, Line 77: isNetmaskValidValue, Line 78: isPrefixValid); -- To view, visit https://gerrit.ovirt.org/35145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If909eda53a61bda5030c342156a01e53576e77cb Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
