Omer Frenkel has posted comments on this change. Change subject: core: in-memory lock for imported vm ......................................................................
Patch Set 6: (1 comment) please add comments in parameters class to document the difference of the multiple vmId in the params https://gerrit.ovirt.org/#/c/38032/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java: Line 94: Line 95: @Override Line 96: protected void postConstruct() { Line 97: T parameters = getParameters(); Line 98: if (parameters.isImportAsNewEntity() && parameters.getVmId().equals(parameters.getVm().getId())) { please check if the second check doesnt break regular clone vm flow Line 99: parameters.getVm().setId(Guid.newGuid()); Line 100: } Line 101: setStoragePoolId(parameters.getStoragePoolId()); Line 102: imageToDestinationDomainMap = parameters.getImageToDestinationDomainMap(); -- To view, visit https://gerrit.ovirt.org/38032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13970306bfc01e11a1d130f5ae818971e18c9634 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
