Sahina Bose has posted comments on this change. Change subject: engine: Changes to brick sync for storage network ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38148/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java: Line 233: Line 234: private Network getGlusterNetworkId(VdsStatic server, String networkAddress) { Line 235: List<Network> allNetworksInCluster = Line 236: DbFacade.getInstance().getNetworkDao().getAllForCluster(server.getVdsGroupId()); Line 237: > Don't we need to check whether the interface of the host is associated with Yes, I will add this check...I think the networkAddress was passed to this function to do this, but I'd removed this check as I did a networkAddress check earlier. But this is needed. Line 238: for (Network network : allNetworksInCluster) { Line 239: if (network.getCluster().isGluster()) { Line 240: return network; Line 241: } -- To view, visit https://gerrit.ovirt.org/38148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99f1ed0d9718be79ffac2ac04a36999c93a79ef2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
