Moti Asayag has posted comments on this change. Change subject: engine: Added compat check for gluster task actions ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/36986/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommandTest.java: Line 164: public void canDoActionFailsOnCompat() { Line 165: cmd = spy(createTestCommand(volumeId1)); Line 166: prepareMocks(cmd); Line 167: doReturn(UNSUPPORTED_VERSION).when(vdsGroup).getCompatibilityVersion(); Line 168: assertFalse(cmd.canDoAction()); Please verify the returned can-do-action message is VdcBllMessages.GLUSTER_TASKS_NOT_SUPPORTED_FOR_CLUSTER_LEVEL Line 169: } Line 170: https://gerrit.ovirt.org/#/c/36986/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRemoveGlusterVolumeBricksCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRemoveGlusterVolumeBricksCommandTest.java: Line 223: public void canDoActionFailsOnCompat() { Line 224: cmd = spy(createTestCommand(volumeId2, 0)); Line 225: prepareMocks(cmd); Line 226: doReturn(UNSUPPORTED_VERSION).when(vdsGroup).getCompatibilityVersion(); Line 227: assertFalse(cmd.canDoAction()); same here Line 228: } -- To view, visit https://gerrit.ovirt.org/36986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70ee8230253b04141133ccb639e00531086fd5bd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
