Shubhendu Tripathi has posted comments on this change. Change subject: engine: vds commands for gluster brick create ......................................................................
Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/36029/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java: Line 175: * Get Host capabilities Line 176: */ Line 177: GetCapabilities("org.ovirt.engine.core.vdsbroker.vdsbroker"); Line 178: Line 179: Unwanted line Line 180: String packageName; Line 181: Line 182: private VDSCommandType(String packageName) { Line 183: this.packageName = packageName; https://gerrit.ovirt.org/#/c/36029/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/CreateBrickVDSParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/CreateBrickVDSParameters.java: Line 9: Line 10: /** Line 11: * VDS Command parameters class for the "Create Brick" action, with the list of Storage Devices Line 12: */ Line 13: public class CreateBrickVDSParameters extends VdsIdVDSCommandParametersBase { Add a toString() method. Refer https://gerrit.ovirt.org/#/c/36293/13/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeSnapshotSetConfigVDSParameters.java Line 14: Line 15: private String lvName; Line 16: private List<StorageDevice> storageDevices; Line 17: private Map<String, Object> raidParams; -- To view, visit https://gerrit.ovirt.org/36029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a74a9eeabd19b9780e4401d263e586261f488d Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
