Moti Asayag has posted comments on this change. Change subject: core: query long-time locks ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38246/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java: Line 312: return null; Line 313: } Line 314: Line 315: Set<String> messages = internalLockView.getMessages(); Line 316: messages.remove(VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED); > Yes, I saw that in jenkins, Done For the protocol I'd like to declare that I noticed this issue without jenkins :-) Line 317: if (messages.isEmpty()) { Line 318: // VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED should only be used for Line 319: // short locks (locks for the execute phase) so we filter it and if no Line 320: // other lock exists, the entity should be displayed as unlocked -- To view, visit https://gerrit.ovirt.org/38246 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafcab44ef52d21405eeaaeb2cda4c03864a0e8e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
