Shubhendu Tripathi has posted comments on this change. Change subject: engine: sync job for gluster disk provisioning ......................................................................
Patch Set 9: (6 comments) https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java: Line 83: else Below could have been logged by VDS layer already?? Line 125: getStorageDeviceDao Try to use updateAllInBatch mechanism https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java: Line 13: VdsActionParameters VdsActionParameterBase or VdcActionParametersBase?? Line 13: VdsCommand extends VdsCommand or CommandBase ?? Line 21: getDbFacade possible npe for cluster https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1162: ACTION_TYPE_FAILED_GEOREP_SESSION_STOPPED=Cannot ${action} ${type}. Geo-replication session is stopped. Line 1163: ACTION_TYPE_FAILED_GEOREP_SESSION_ALREADY_STARTED=Cannot ${action} ${type}. Geo-replication session is already started. Line 1164: ACTION_TYPE_FAILED_GEOREP_SESSION_ALREADY_RESUMED=Cannot ${action} ${type}. Geo-replication session is resumed. Line 1165: ACTION_TYPE_FAILED_GEOREP_SESSION_ALREADY_PAUSED=Cannot ${action} ${type}. Geo-replication session is paused. Line 1166: ACTION_TYPE_FAILED_STORAGE_PROVISIONING_NOT_SUPPORTED_BY_CLUSTER=Cannot sync Storage Devices. The selected cluster doesn't support Storage provisioning. All the messages start with "Cannot ${action} ${type}." Can we do the same here as well? but we would need to set action type. Line 1167: Line 1168: ACTION_TYPE_FAILED_TAG_ID_REQUIRED=Cannot ${action} ${type}. Tag ID is required. Line 1169: Line 1170: ACTION_TYPE_FAILED_QOS_CPU_OUT_OF_RANGE_VALUES=Cannot ${action} ${type}. Values are out of range\n(Legal range is: 1-100). -- To view, visit https://gerrit.ovirt.org/36429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I651bb51873a96d491c5a5f51147cb72be958985a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
