Lior Vernia has posted comments on this change. Change subject: webadmin: avoid sending an empty ManageNetworkClusteers command ......................................................................
Patch Set 1: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/38209/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java: Line 183: } Line 184: } Line 185: Line 186: private void attachNetworkToClusters(Guid networkGuid) { Line 187: final Guid networkId = getNetwork().getId() == null ? networkGuid : getNetwork().getId(); The difference between the variables named "networkId" and "networkGuid" isn't really clear from their naming... I'd just move the ?: logic to the invocation of the method and get rid of the local variable. Line 188: final List<NetworkCluster> networkAttachments = new ArrayList<>(); Line 189: Line 190: for (NetworkClusterModel networkClusterModel : getClustersToAttach()) { Line 191: // Init default NetworkCluster values (required, display, status) -- To view, visit https://gerrit.ovirt.org/38209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0744c499a6034c92aad1072daa7442e51a7d984 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
