Allon Mureinik has posted comments on this change. Change subject: api: Add created Disk object on import response ......................................................................
Patch Set 3: Code-Review+1 (2 comments) Code looks fine, some minor suggestions on the commit msg. https://gerrit.ovirt.org/#/c/38255/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-03-01 16:51:42 +0200 Line 6: Line 7: api: Add created Disk object on import response Line 8: Line 9: When doing IMAGE-ID/import with async=false, the response returns the I'd give a full path here, just to make the context clearer: /ovirt-engine/api/... Line 10: created disk object Line 11: Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1169228 Line 13: Change-Id: Ic7a6203a318763f13fca8f0627bb0188b7eb2984 Line 7: api: Add created Disk object on import response Line 8: Line 9: When doing IMAGE-ID/import with async=false, the response returns the Line 10: created disk object Line 11: Also probably examples of the input and the output. Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1169228 Line 13: Change-Id: Ic7a6203a318763f13fca8f0627bb0188b7eb2984 -- To view, visit https://gerrit.ovirt.org/38255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7a6203a318763f13fca8f0627bb0188b7eb2984 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
