Daniel Erez has posted comments on this change. Change subject: webadmin: Warning on dependent VMs on delete template ......................................................................
Patch Set 8: (3 comments) https://gerrit.ovirt.org/#/c/37514/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java: Line 109: } Line 110: } Line 111: }), Line 112: getEntity().getId()); Line 113: cancel(); should be removed. the window should be closed only upon action completion. Line 114: } Line 115: Line 116: private void getVmsFromExportDomain(Guid dataCenterId, Guid storageDomainId) { Line 117: Frontend.getInstance().runQuery(VdcQueryType.GetVmsFromExportDomain, Line 203: setConfirmWindow(null); Line 204: } Line 205: Line 206: private void removeTemplateBackup() { Line 207: AsyncDataProvider.getInstance().getDataCentersByStorageDomain(new AsyncQuery(this, new INewAsyncCallback() { why do u need to call it again (it's already called in line 100) ? Line 208: Line 209: @Override Line 210: public void onSuccess(Object model, Object returnValue) { Line 211: TemplateBackupModel templateBackupModel = (TemplateBackupModel) model; Line 221: pool.getId())); Line 222: } Line 223: Line 224: Frontend.getInstance().runMultipleAction(VdcActionType.RemoveVmTemplateFromImportExport, prms); Line 225: cancel(); call cancel either way (i.e. move to line 227) - just in case... Line 226: } Line 227: Line 228: } Line 229: }), -- To view, visit https://gerrit.ovirt.org/37514 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cba5df5a41973741a855ae0c9efddd56100d2fd Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Candace Sheremeta <csher...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Fred Rolland <froll...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
