Shubhendu Tripathi has posted comments on this change. Change subject: webadmin: UI to set the volume snapshot configurations ......................................................................
Patch Set 13: (2 comments) https://gerrit.ovirt.org/#/c/36295/13/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 538: getStopVolumeProfilingCommand().setIsExecutionAllowed(allowStopProfiling); Line 539: getShowVolumeProfileDetailsCommand().setIsExecutionAllowed(allowProfileStatisticsDetails); Line 540: } Line 541: Line 542: private boolean isSnapshotActionsAvailable(List<GlusterVolumeEntity> list) { > is this being used? No. will remove this Line 543: if (getSelectedItems().size() == 1) { Line 544: GlusterVolumeEntity volumeEntity = list.get(0); Line 545: return (volumeEntity.getStatus() == GlusterStatus.UP); Line 546: } else { Line 1207: })); Line 1208: Line 1209: clusterSnapshotConfigModel.getClusterConfigOptions().setTitle(ConstantsManager.getInstance() Line 1210: .getConstants() Line 1211: .configureClusterSnapshotOptionsTitle()); > is this being reflected in the ui? yes. it shows properly Line 1212: Line 1213: UICommand updateCommand = new UICommand("confirmConfigureClusterSnapshotOptions", this); //$NON-NLS-1$ Line 1214: updateCommand.setTitle(constants.snapshotConfigUpdateButtonLabel()); Line 1215: updateCommand.setIsDefault(true); -- To view, visit https://gerrit.ovirt.org/36295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08b5e592b818266106bc1891c3aa2f3ba3541d36 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
