Fabian Deutsch has posted comments on this change. Change subject: autoinstall: handle autoinstall params ......................................................................
Patch Set 1: (6 comments) https://gerrit.ovirt.org/#/c/38161/1/autoinstall/autoreg.py File autoinstall/autoreg.py: Line 50: : We do not need the loop IIUIC. Because the if … statements basically all possible cases and it's enough to have them (with some modifications) Line 54: if With the dropped for loop you can do the following: if is_karg_set("management_server"): … Line 61: elif This should become an if, if the for loop is dropped. Line 61: "management_server_port" This can be dropped with the dropped for loop Line 75: elif SShould be if if we drop the for loop Line 75: "rhevm_admin_password" == key Can be dropped, if we drop the for loop -- To view, visit https://gerrit.ovirt.org/38161 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf664eb61344067427e4d88617dbbb7e8dd1d517 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
