Martin Betak has posted comments on this change. Change subject: frontend: refactoring: Generify list models ......................................................................
Patch Set 22: (1 comment) https://gerrit.ovirt.org/#/c/32907/22/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java: Line 285: syntaxChecker = SyntaxCheckerFactory.createUISyntaxChecker( Line 286: (String) AsyncDataProvider.getInstance().getConfigValuePreConverted(ConfigurationValues.AuthenticationMethod)); Line 287: } Line 288: Line 289: entityModel = new EntityModel<E>() { > Could you elaborate on why the overridden functionality is broken? If you h the problem is the use case is opposite: entity model calls onEntityChanged when the entity changes and subclasses react to it by overriding this method. if SearchableListModel's method would delegate to entityModel, entityModel's "notifications" would be lost as there would be no connection in the direction EntityModel -> subclass overrides. Essentially subclasses of SearchableListModel would (in patchset 24) override method that is never called - and I noticed the consequences that all SubTabs were in the state of "loading..." when I opened webadmin. The structure of the code needs to stay like this. Line 290: @Override Line 291: protected void onEntityChanged() { Line 292: SearchableListModel.this.onEntityChanged(); Line 293: } -- To view, visit https://gerrit.ovirt.org/32907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f1671a5839fe31b49ad0d1c99bad84e5f0c7c4 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
