Moti Asayag has posted comments on this change. Change subject: codegen: Avoid calculation of singulars and plurals ......................................................................
Patch Set 4: Code-Review+1 (1 comment) Same as Martin. It was nice seeing the first usage of java8 syntax in one of ovirt projects https://gerrit.ovirt.org/#/c/37868/4/generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/Action.java File generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/Action.java: Line 1: // Line 2: // Copyright (c) 2014 Red Hat, Inc. 2015 ? Line 3: // Line 4: // Licensed under the Apache License, Version 2.0 (the "License"); Line 5: // you may not use this file except in compliance with the License. Line 6: // You may obtain a copy of the License at -- To view, visit https://gerrit.ovirt.org/37868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b27061d436e524683dbed81c5521eed51e8c2f0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches