Liron Aravot has posted comments on this change. Change subject: core: Add managed devices to OVF ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/38120/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfUpdateProcessHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfUpdateProcessHelper.java: Line 102: ()); this seems to add also unmanaged devices, which isn't intentent. Line 103: { disk device will be duplicated now, have you checked that import storage domain/add vm from ovf scenarios working fine? -- To view, visit https://gerrit.ovirt.org/38120 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e912c9b2950f1461ae95f4704f18b818b83a3b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
