Simone Tiraboschi has posted comments on this change. Change subject: setup: checking if command_entities table exist ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37847/2/packaging/setup/dbutils/taskcleaner.sh File packaging/setup/dbutils/taskcleaner.sh: Line 123: if [[ $VERSION = 0 ]]; then Line 124: VERSION="3.5" Line 125: else Line 126: VERSION="3.4" Line 127: dbfunc_psql_die --command="create table command_entities ();" > Not sure, You have it if you are upgrading, you don't need it otherwise. I'm not that sure that creating the table here is a good idea. Line 128: fi Line 129: Line 130: if [ "${TASK_ID}" != "" -o "${COMMAND_ID}" != "" -o -n "${CLEAR_ALL}" -o -n "${CLEAR_COMPENSATION}" -o -n "${CLEAR_JOB_STEPS}" ]; then #delete operations block Line 131: if [ -n "${TASK_ID}" ]; then -- To view, visit http://gerrit.ovirt.org/37847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3152c4d3f6e02915053ada5019abeea7cb356751 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
