Tomas Jelinek has posted comments on this change. Change subject: webadmin: added the instance images widget to new/edit VM dialog ......................................................................
Patch Set 16: (2 comments) http://gerrit.ovirt.org/#/c/36064/16/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java: Line 267: @Override Line 268: public void onSuccess(Object model, Object returnValue) { Line 269: List<InstanceImageLineModel> imageLineModels = new ArrayList<>(); Line 270: Line 271: for (Disk disk : ((ArrayList<Disk>) returnValue)) { > should verify that the return value isn't null The converter callback already takes care of this in AsyncDataProvider.getVmDiskList() Line 272: InstanceImageLineModel lineModel = new InstanceImageLineModel(getModel().getInstanceImages()); Line 273: lineModel.initialize(disk, getVm()); Line 274: imageLineModels.add(lineModel); Line 275: } http://gerrit.ovirt.org/#/c/36064/16/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java: Line 167: return importClonePopupProvider.get(); Line 168: } else if ("OnSave".equals(lastExecutedCommand.getName())) { //$NON-NLS-1$ Line 169: return nextRunProvider.get(); Line 170: } else if (lastExecutedCommand == getModel().getEditCommand()) { Line 171: return removeDiskConfirmPopupProvider.get(); > is the confirmation displayed when removing disk only on edit vm? yes, because in the new vm dialog the disks are not yet created and attached to the VM. But now as I have tested it again I found out that there is a mistake that even if you do "cancel" it removes the disk :) Fixed in the "frontend: created instance image widget" patch. Line 172: } else { Line 173: return super.getConfirmModelPopup(source, lastExecutedCommand); Line 174: } Line 175: } -- To view, visit http://gerrit.ovirt.org/36064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I792340b0bfb632f956961959f36f79d841cad50a Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
