Shubhendu Tripathi has posted comments on this change. Change subject: gluster: BLL commands for gluster volume snapshot actions ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/37325/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RestoreGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RestoreGlusterVolumeSnapshotCommand.java: Line 59: return; Line 60: } else { Line 61: GlusterVolumeSnapshotEntity slaveVolumeSnapshot = Line 62: getGlusterVolumeSnapshotDao().getByName(slaveVolume.getId(), Line 63: getParameters().getSnapshotName()); > Null check? done Line 64: VDSReturnValue slaveRestoreRetVal = Line 65: runVdsCommand(VDSCommandType.RestoreGlusterVolumeSnapshot, Line 66: new GlusterVolumeSnapshotActionVDSParameters(slaveUpServer.getId(), Line 67: slaveVolume.getName(), -- To view, visit http://gerrit.ovirt.org/37325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74fa567e0910a8f97c3d127951481448983e3fd3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
