Idan Shaby has posted comments on this change. Change subject: packaging: setup: SANWipeAfterDelete configuration ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/37397/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/storage.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/storage.py: Line 1: # Line 2: # ovirt-engine-setup -- ovirt engine setup Line 3: # Copyright (C) 2013 Red Hat, Inc. > 2015 Done Line 4: # Line 5: # Licensed under the Apache License, Version 2.0 (the "License"); Line 6: # you may not use this file except in compliance with the License. Line 7: # You may obtain a copy of the License at Line 37: Line 38: @util.export Line 39: class Plugin(plugin.PluginBase): Line 40: """storage plugin.""" Line 41: > You also need to initialize the new env variables to a default value at STA Done Line 42: @plugin.event( Line 43: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 44: before=( Line 45: oengcommcons.Stages.DIALOG_TITLES_E_STORAGE, Line 50: condition=lambda self: Line 51: self.environment[oenginecons.EngineDBEnv.NEW_DATABASE], Line 52: ) Line 53: def _configureSANWipeAfterDelete(self): Line 54: sanWipeAfterDelete = dialog.queryBoolean( > Good idea, but the suggested code is unreadable. I added the condition, thanks. Line 55: dialog=self.dialog, Line 56: name='OVESETUP_CONFIG_SAN_WIPE_AFTER_DELETE', Line 57: note=_( Line 58: 'Default SAN wipe after delete ' -- To view, visit http://gerrit.ovirt.org/37397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I911f87ad34eafc83eb2c7aa346fc4278ada28b5b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Candace Sheremeta <csher...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
