Moti Asayag has submitted this change and it was merged. Change subject: core: MultipleActionsRunner refactor: extracted canRunActions method from execute() ......................................................................
core: MultipleActionsRunner refactor: extracted canRunActions method from execute() method execute() is overgrown and disallowing modifications in subclasses. There are Commands written in a way disallowing separating method calls of 'canDoAction'and 'execute'. Calling all 'canDoAction' methods prior to calling first 'execute' yields bad results, therefore, canDoAction have to be called prior to respective execute method. Change-Id: Id0c8b741d5a8ddce3caf5177d77285132bb1053b Signed-off-by: Martin Mucha <mmu...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java 1 file changed, 11 insertions(+), 9 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0c8b741d5a8ddce3caf5177d77285132bb1053b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
