Daniel Erez has posted comments on this change. Change subject: webadmin: Refactoring GlusterModel to inherit from PosixModel. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37893/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java: Line 495: boolean isPathEditable = isPathEditable(storage); Line 496: model.getPath().setIsChangable(isPathEditable); Line 497: Line 498: // vfs type is changeable only for general posix storage. Line 499: if (model.getType().equals(StorageType.POSIXFS)) { maybe worth moving this logic to gluster/posix models instead of checking the type? Line 500: model.getVfsType().setIsChangable(isPathEditable); Line 501: } else { Line 502: model.getVfsType().setIsChangable(false); Line 503: } -- To view, visit http://gerrit.ovirt.org/37893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a355956f0f30a79f13d0bd72ec7a4d65cc29d1a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
