Greg Sheremeta has uploaded a new change for review.
Change subject: userportal, webadmin: added 'Click for help' tooltip to help
icons
......................................................................
userportal, webadmin: added 'Click for help' tooltip to help icons
Change-Id: Ifdf3eecb3603f0f818a32a1813c7890b9ed1ac1e
Signed-off-by: Greg Sheremeta <gsher...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml
3 files changed, 21 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/92/37992/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
index 160c813..d8197a3 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
@@ -2075,4 +2075,7 @@
@DefaultStringValue("Kdumping")
String kdumping();
+ @DefaultStringValue("Click for help")
+ String clickForHelp();
+
}
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java
index b7540ce..75432dc 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java
@@ -1,5 +1,7 @@
package org.ovirt.engine.ui.common.widget.dialog;
+import org.ovirt.engine.ui.common.CommonApplicationConstants;
+import org.ovirt.engine.ui.common.widget.tooltip.WidgetTooltip;
import org.ovirt.engine.ui.uicommonweb.UICommand;
import com.google.gwt.core.client.GWT;
@@ -16,6 +18,8 @@
import com.google.gwt.user.client.ui.Widget;
public class SimpleDialogPanel extends AbstractDialogPanel {
+
+ private static final CommonApplicationConstants constants =
GWT.create(CommonApplicationConstants.class);
interface WidgetUiBinder extends UiBinder<Widget, SimpleDialogPanel> {
WidgetUiBinder uiBinder = GWT.create(WidgetUiBinder.class);
@@ -52,6 +56,9 @@
ButtonBase closeIconButton;
@UiField
+ WidgetTooltip helpIconButtonTooltip;
+
+ @UiField
Style style;
private UICommand helpCommand;
@@ -60,6 +67,8 @@
setWidget(WidgetUiBinder.uiBinder.createAndBindUi(this));
getElement().getStyle().setZIndex(1);
addHelpButtonHandler();
+ helpIconButtonTooltip.setText(constants.clickForHelp());
+ helpIconButtonTooltip.reconfigure();
}
@Override
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml
index 9a42385..557c50f 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml
@@ -1,6 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE ui:UiBinder SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent";>
-<ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder"
xmlns:g="urn:import:com.google.gwt.user.client.ui">
+<ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder"
xmlns:g="urn:import:com.google.gwt.user.client.ui"
+xmlns:t="urn:import:org.ovirt.engine.ui.common.widget.tooltip">
<ui:with field='resources'
type='org.ovirt.engine.ui.common.CommonApplicationResources' />
@@ -121,11 +122,13 @@
</g:SimplePanel>
<g:FlowPanel
addStyleNames="{style.obrand_dialogHeaderTitleContainer}">
<g:FlowPanel ui:field="headerTitlePanel">
- <g:PushButton ui:field="helpIconButton"
addStyleNames="{style.helpIconButton}" visible="false">
- <g:upFace image='{resources.dialogIconHelp}' />
- <g:downFace image='{resources.dialogIconHelpDown}'
/>
- <g:upHoveringFace
image='{resources.dialogIconHelpRollover}' />
- </g:PushButton>
+ <t:WidgetTooltip ui:field="helpIconButtonTooltip">
+ <g:PushButton ui:field="helpIconButton"
addStyleNames="{style.helpIconButton}" visible="false">
+ <g:upFace image='{resources.dialogIconHelp}' />
+ <g:downFace
image='{resources.dialogIconHelpDown}' />
+ <g:upHoveringFace
image='{resources.dialogIconHelpRollover}' />
+ </g:PushButton>
+ </t:WidgetTooltip>
</g:FlowPanel>
</g:FlowPanel>
</g:FlowPanel>
--
To view, visit http://gerrit.ovirt.org/37992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifdf3eecb3603f0f818a32a1813c7890b9ed1ac1e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
