Ravi Nori has uploaded a new change for review.

Change subject: engine : NPE when adding a VM to a VM pool when there's not 
enough storage
......................................................................

engine : NPE when adding a VM to a VM pool when there's not enough storage

NPE in the engine log while adding a vm to
an existing pool, when there is not enough
storage to perform this operation.

Change-Id: I0d53e9505054f9476910154a7677d273293f79c0
Bug-Url: https://bugzilla.redhat.com/1179558
Signed-off-by: Ravi Nori <rn...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/62/37962/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
index f5e764a..a7cdd7e 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
@@ -126,7 +126,7 @@
                     if (context.getExecutionMethod() == ExecutionMethod.AsStep
                             && parentStep != null) {
                         context.setCompleted(true);
-                        if (!exitStatus) {
+                        if (job != null && !exitStatus) {
                             job.markJobEnded(false);
                             JobRepositoryFactory.getJobRepository()
                                     .updateCompletedJobAndSteps(job);


-- 
To view, visit http://gerrit.ovirt.org/37962
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d53e9505054f9476910154a7677d273293f79c0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to