Daniel Erez has posted comments on this change. Change subject: webadmin: Changes in disk popup needed to reuse in VM popup ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/36061/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java: Line 65: new AsyncQuery(this, new GetDisksCallback(DiskStorageType.LUN, prevSelectedDisk), Line 66: getHash()), null, getVm().getId()); Line 67: } Line 68: Line 69: public void loadAttachableDisks(int os, Version compatibilityVersion, final Disk prevSelectedDisk) { > not specific - it is used to load the attachable disks for both attach disk just meant that if this logic is relevant only for instance images then it's probably better to put it in another class that handles all instance images logic - just to keep the code of AbstractDiskModel/AttachDiskModel cleaner. Line 70: // Get internal attachable disks Line 71: AsyncDataProvider.getInstance().getFilteredAttachableDisks( Line 72: new AsyncQuery(this, new GetDisksCallback(DiskStorageType.IMAGE, prevSelectedDisk), Line 73: getHash()), getVm().getStoragePoolId(), getVm().getId(), os, compatibilityVersion); -- To view, visit http://gerrit.ovirt.org/36061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52c5d5c7b83dd53cea3a9419656015e6a51bd179 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Candace Sheremeta <csher...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
