Maor Lipchuk has posted comments on this change. Change subject: core: remove dead code of template deletion by SD ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/37907/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java: Line 105: if (!isInstanceType) { Line 106: fetchImageTemplates(); Line 107: } Line 108: Line 109: Set<Guid> allDomainsList = getStorageDomainsByDisks(imageTemplates, true); please put the comment before line 109, or simply add an empty line between the comment and line 109 Line 110: // populate all the domains of the template Line 111: getParameters().setStorageDomainsList(new ArrayList<Guid>(allDomainsList)); Line 112: Line 113: // check template images for selected domains -- To view, visit http://gerrit.ovirt.org/37907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea08a582e5887a5458efef0870f18af83046f4fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
