Allon Mureinik has posted comments on this change. Change subject: webadmin, engine: Gluster domain edit enhancement. ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/37894/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-02-18 11:17:39 +0200 Line 6: Line 7: webadmin, engine: Gluster domain edit enhancement. Line 8: Line 9: Gluster domain's connection and mount options editing was disabled in webadmin and engine. Please keep lines no longer than 70 chars. Line 10: This patch adds the possibility to edit it. Line 11: Line 12: Change-Id: I7320520a15fe804a3a560bf1b8223bfee5b1b46a Line 13: Bug-Url: https://bugzilla.redhat.com/1168686 http://gerrit.ovirt.org/#/c/37894/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java: Line 1392: Line 1393: if (storageModel.getType().equals(StorageType.NFS)) { Line 1394: updateNFSProperties(storageModel); Line 1395: } Line 1396: else if (storageModel instanceof PosixStorageModel) { Why do you need this change? Line 1397: updatePosixProperties(storageModel); Line 1398: } Line 1399: Line 1400: StorageServerConnectionParametersBase parameters = -- To view, visit http://gerrit.ovirt.org/37894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7320520a15fe804a3a560bf1b8223bfee5b1b46a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
