Moti Asayag has posted comments on this change. Change subject: core: Fixing possible NPE ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37738/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 316: final String hostNameFact = "facts.network.hostname:" + host.getHostName(); Line 317: final List<ContentHost> contentHosts = Line 318: runContentHostListMethod(CONTENT_HOSTS_ENTRY_POINT + String.format(SEARCH_QUERY_FORMAT, hostNameFact)); Line 319: Line 320: if (CollectionUtils.isEmpty(contentHosts)) { > please provide correct gerrit URL you want me to check. sorry - I wrongly typed the current url. it was already merged - http://gerrit.ovirt.org/#/c/37765/ Line 321: log.error("Failed to find host on provider by host name '{}' ", host.getHostName()); Line 322: return null; Line 323: } Line 324: -- To view, visit http://gerrit.ovirt.org/37738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04c462c0d2b1d0a326c4c80f66360d036be2fbc9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
