Shubhendu Tripathi has posted comments on this change. Change subject: gluster: BLL command for volume snapshot create ......................................................................
Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/34928/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java: Line 70: for (GlusterGeoRepSession session : geoRepSessions) { Line 71: if (session.getStatus() == GeoRepSessionStatus.ACTIVE) { Line 72: GlusterVolumeEntity slaveVolume = Line 73: getDbFacade().getGlusterVolumeDao().getById(session.getSlaveVolumeId()); Line 74: VDS slaveUpServer = ClusterUtils.getInstance().getRandomUpServer(slaveVolume.getClusterId()); > Sorry, for remote cluster to pause the session we need an up server from th Got confused here. For Pause we need master cluster's up-server and for snapshot creation for slave we need slave up server. Will change accordingly. Line 75: Line 76: // Pause the geo-rep session Line 77: VdcReturnValueBase sessionPauseRetVal = Line 78: getBackend().runAction(VdcActionType.PauseGlusterVolumeGeoRepSession, -- To view, visit http://gerrit.ovirt.org/34928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c27f9e73bac8d6de3022b0dd4e70aa0d8b1494b Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
