Ravi Nori has posted comments on this change. Change subject: core : Add Entity API for CoCo commands ......................................................................
Patch Set 2: (1 comment) @Yair I kept it very similar to AsyncTaskEntities. http://gerrit.ovirt.org/#/c/37463/2/packaging/dbscripts/upgrade/03_06_0890_add_coco_cmd_entities_table.sql File packaging/dbscripts/upgrade/03_06_0890_add_coco_cmd_entities_table.sql: Line 3: entity_id uuid NOT NULL, Line 4: entity_type character varying(128) Line 5: ); Line 6: Line 7: SELECT fn_db_create_constraint('coco_cmd_entities', 'fk_coco_cmd_entity', 'FOREIGN KEY (command_id) REFERENCES command_entities(command_id) ON DELETE CASCADE'); > Maybe "command_assoc_entities" ? I thought very hard and could not come up with a good name :) command_assoc_entities sounds better -- To view, visit http://gerrit.ovirt.org/37463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96b934ffc44f87407df77c8e097164ca30f3a6e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
